Dave Jiang wrote: > Create callback function to support the nvdimm_security_ops ->change_key() > callback. Translate the operation to send "Set Passphrase" security command > for CXL memory device. The operation supports setting a passphrase for the > CXL persistent memory device. It also supports the changing of the > currently set passphrase. The operation allows manipulation of a user > passphrase or a master passphrase. > > See CXL rev3.0 spec section 8.2.9.8.6.2 for reference. > > However, the spec leaves a gap WRT master passphrase usages. The spec does > not define any ways to retrieve the status of if the support of master > passphrase is available for the device, nor does the commands that utilize > master passphrase will return a specific error that indicates master > passphrase is not supported. If using a device does not support master > passphrase and a command is issued with a master passphrase, the error > message returned by the device will be ambiguos.
s/ambiguos/ambiguous/ Other than that, looks good.
