On Wed, 30 Nov 2022 12:21:36 -0700 Dave Jiang <[email protected]> wrote:
> Add nvdimm_security_ops support for CXL memory device with the introduction > of the ->get_flags() callback function. This is part of the "Persistent > Memory Data-at-rest Security" command set for CXL memory device support. > The ->get_flags() function provides the security state of the persistent > memory device defined by the CXL 3.0 spec section 8.2.9.8.6.1. > > Reviewed-by: Jonathan Cameron <[email protected]> > Signed-off-by: Dave Jiang <[email protected]> > Link: > https://lore.kernel.org/r/166863346914.80269.2104235260504076729.st...@djiang5-desk3.ch.intel.com > Signed-off-by: Dan Williams <[email protected]> Hi Dave / Dan, Just looking at build warnings with current upstream with W=1 C=1 and it highlights and oddity with this patch. > diff --git a/drivers/cxl/pmem.c b/drivers/cxl/pmem.c > index 4c627d67281a..efffc731c2ec 100644 > --- a/drivers/cxl/pmem.c > +++ b/drivers/cxl/pmem.c > @@ -11,6 +11,8 @@ > #include "cxlmem.h" > #include "cxl.h" > > +extern const struct nvdimm_security_ops *cxl_security_ops; Why not push this into a header as... > + > /* > * Ordered workqueue for cxl nvdimm device arrival and departure > * to coordinate bus rescans when a bridge arrives and trigger remove > @@ -78,8 +80,8 @@ static int cxl_nvdimm_probe(struct device *dev) > set_bit(ND_CMD_GET_CONFIG_SIZE, &cmd_mask); > set_bit(ND_CMD_GET_CONFIG_DATA, &cmd_mask); > set_bit(ND_CMD_SET_CONFIG_DATA, &cmd_mask); > - nvdimm = nvdimm_create(cxl_nvb->nvdimm_bus, cxl_nvd, NULL, flags, > - cmd_mask, 0, NULL); > + nvdimm = __nvdimm_create(cxl_nvb->nvdimm_bus, cxl_nvd, NULL, flags, > + cmd_mask, 0, NULL, NULL, cxl_security_ops, > NULL); > if (!nvdimm) { > rc = -ENOMEM; > goto out; > diff --git a/drivers/cxl/security.c b/drivers/cxl/security.c > new file mode 100644 > index 000000000000..806173084216 > --- /dev/null > +++ b/drivers/cxl/security.c > + > +static const struct nvdimm_security_ops __cxl_security_ops = { > + .get_flags = cxl_pmem_get_security_flags, > +}; > + > +const struct nvdimm_security_ops *cxl_security_ops = &__cxl_security_ops; otherwise this triggers a should static warning as the compiler can't see the extern definition. Jonathan
