On Mon, 7 Aug 2023 15:35:47 +0900 Jehoon Park <[email protected]> wrote:
> Update the predefined value for device temperature field when it is not > implemented. (CXL 3.0.8.2.9.8.3.1) > > Signed-off-by: Jehoon Park <[email protected]> Hi Jehoon, Key here is not that it was in 3.0, but that it was changed in 2.0 Errata F38 and as such software doesn't need to cope with the old (wrong) value. Good to state that clearly in the patch description. If it had been merely a change for 3.0 there would have needed to be an enable bit to change the default behavior (or something like that). Otherwise LGTM Reviewed-by: Jonathan Cameron <[email protected]> > --- > cxl/lib/private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cxl/lib/private.h b/cxl/lib/private.h > index a641727..a692fd5 100644 > --- a/cxl/lib/private.h > +++ b/cxl/lib/private.h > @@ -360,7 +360,7 @@ struct cxl_cmd_set_partition { > #define CXL_CMD_HEALTH_INFO_EXT_CORRECTED_PERSISTENT_WARNING (1) > > #define CXL_CMD_HEALTH_INFO_LIFE_USED_NOT_IMPL > 0xff > -#define CXL_CMD_HEALTH_INFO_TEMPERATURE_NOT_IMPL 0xffff > +#define CXL_CMD_HEALTH_INFO_TEMPERATURE_NOT_IMPL 0x7fff > > static inline int check_kmod(struct kmod_ctx *kmod_ctx) > {
