Dave Jiang wrote:
[..]
> Ah that was a mistake. I meant to call the query function and not the
> online op function. Do you have any objections to
> 
> if (!daxctl_memory_is_movable(mem))

Wait, why check for movable? ZONE_NORMAL can be removed if you are
lucky, and ZONE_MOVABLE may still not be able to be removed if you are
unlucky. So I would expect that disable-region attempts to offline
all-memory blocks, and if that fails then fail the disable-region. That
would of course need to come with documentation that disable-region may
leave the memory in a partially offline state. Then the force can just
rip the device away with the warning message that physical address space
has now been permanently leaked and can not be recovered until a reboot.

Reply via email to