On Wed, Nov 15, 2023 at 02:13:48AM -0800, Vishal Verma wrote:
> On Sun, 2023-10-01 at 15:31 -0700, [email protected] wrote:
> > From: Alison Schofield <[email protected]>
> >
> > Exercise cxl list, libcxl, and driver pieces of the get poison list
> > pathway. Inject and clear poison using debugfs and use cxl-cli to
> > read the poison list by memdev and by region.
> >
> > Signed-off-by: Alison Schofield <[email protected]>
> > ---
snip
> > +cxl list
>
> "$CXL" list
>
> Also should reset rc from 77 so that it doesn't show as skipped on a
> real failure.
Done.
>
snip
> > +setup_x2_region()
> > +{
> > + # Find an x2 decoder
> > + decoder=$($CXL list -b cxl_test -D -d root | jq -r ".[] |
>
> I suspect this comes from another test, but test/common defines a
> $cxl_test_bus that can be used here.
Done.
>
snip
> > +find_media_errors()
> > +{
> > + nr=$(echo $json | jq -r ".nr_poison_records")
>
> No need for echo and pipe -
>
> nr="$(jq -r ".nr_poison_records" <<< "$json")"
Done
>
> Also, this currently assumes that a global '$json' will be available
> and up to date. In this test the way it is called, this will always be
> true, but it would be cleaner to actually pass $json to
> find_media_errors() each time, and in here, do something like
>
> local json="$1"
>
Done
> > + if [[ $nr -ne $NR_ERRS ]]; then
>
> If using the bash variant, [[ ]], this should be
>
> if [[ $nr != $NR_ERRS ]]; then
>
Done
> > + echo "$mem: $NR_ERRS poison records expected, $nr found"
> > + err "$LINENO"
> > + fi
> > +}
> > +
snip
> > +find_media_errors
>
> For all of the above debugfs writes -
>
> mem1 is hard-coded - is this supposed to be "$mem1" from when
> setup_x2_region() was done (similar to how the region stuff is done
> below)?
It was intentionally hardcoded based on what I expect in the
cxl-test topology.
Changed it in v3 to look up a memdev.
>
> > +
> > +# Poison by region: inject, list, clear, list.
> > +setup_x2_region
> > +create_region
> > +echo 0x40000000 > /sys/kernel/debug/cxl/"$mem0"/inject_poison
> > +echo 0x40000000 > /sys/kernel/debug/cxl/"$mem1"/inject_poison
> > +NR_ERRS=2
> > +json=$("$CXL" list -r "$region" --poison | jq -r '.[].poison')
> > +find_media_errors
> > +echo 0x40000000 > /sys/kernel/debug/cxl/"$mem0"/clear_poison
> > +echo 0x40000000 > /sys/kernel/debug/cxl/"$mem1"/clear_poison
>
> It might be nice to create a couple of helpers -
>
> inject_poison_sysfs() {
> memdev="$1"
> addr="$2
> ...
> }
>
> And similarly
>
> clear_poison_sysfs()...
>
Done
Thanks for the review Vishal, especially the bash & jq wisdom!
> >
