Li Zhijian wrote: > A space is missing before ']' > > Acked-by: Dan Williams <[email protected]>
You added my Ack without addressing the feedback. "Commentary on the impact of the change is always welcome." Please include a sentence on how this triggered for you and some analysis of the why it has not triggered previously. Otherwise "A space is missing before ']'" does not add any information that can not be determined by reading the patch. A useful changelog for this would be something like: Currently the cxl-region-sysfs.sh test runs to completion and passes, but with syntax errors in the log. It turns out that because the test is checking for a positive condition as a failure, that also happens to mask the syntax errors. Fix the syntax and note that this also happens to unblock a test case that was being hidden by this error.
