On Tue, Jan 16, 2024 at 01:17:23PM -0800, Dan Williams wrote:
> Prevent warnings of the form:
> 
> tools/testing/nvdimm/config_check.c:4:6: error: no previous prototype
> for ‘check’ [-Werror=missing-prototypes]
> 
> ...by locally disabling some warnings.
> 
> It turns out that:
> 
> Commit 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes 
> globally")
> 
> ...in addition to expanding in-tree coverage, also impacts out-of-tree
> module builds like those in tools/testing/nvdimm/.
> 
> Filter out the warning options on unit test code that does not effect
> mainline builds.
> 
> Signed-off-by: Dan Williams <[email protected]>

Reviewed-by: Alison Schofield <[email protected]>

> ---
>  tools/testing/nvdimm/Kbuild |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/nvdimm/Kbuild b/tools/testing/nvdimm/Kbuild
> index 8153251ea389..91a3627f301a 100644
> --- a/tools/testing/nvdimm/Kbuild
> +++ b/tools/testing/nvdimm/Kbuild
> @@ -82,4 +82,6 @@ libnvdimm-$(CONFIG_NVDIMM_KEYS) += $(NVDIMM_SRC)/security.o
>  libnvdimm-y += libnvdimm_test.o
>  libnvdimm-y += config_check.o
>  
> +KBUILD_CFLAGS := $(filter-out -Wmissing-prototypes -Wmissing-declarations, 
> $(KBUILD_CFLAGS))
> +
>  obj-m += test/
> 
> 

Reply via email to