Shiyang Ruan wrote:
> Restore the tracepoint that was accidentally deleted before, and rename
> to dax_insert_entry().  Also, since we are using XArray, rename
> 'radix_entry' to 'xa_entry'.

The restore tracepoint patch should be an independent patch.

As for the rename I believe that can potentially break peoples existing
scripts.

So we can try to change it and see if someone screams, but if that needs
to be reverted then having it as a separate patch from the fix makes it
easier to manage.

Effectively, any time you write "Also," in a patch that is usually a
good sign to break up the patch.

Reply via email to