Hi Alison,
On Mon, 30 Sep 2024, Alison Schofield wrote:\n
+ [email protected]
On Sat, Sep 28, 2024 at 02:16:42PM -0700, Davidlohr Bueso wrote:
Add a new cxl_memdev_sanitize() to libcxl to support triggering memory
device sanitation, in either Sanitize and/or Secure Erase, per the
CXL 3.0 spec.
This is analogous to 'ndctl sanitize-dimm'.
Signed-off-by: Davidlohr Bueso <[email protected]>
Hi David,
I'm wrangling patches for ndctl now and need your help with this one.
Ah I missed that, sorry I didn't Cc you.
Looking at the lore history, you posted a patchset for wait-sanitize &
sanitize-memdev in Apr'03.[1] and update with rev2.[2] Later in Oct'23
Dan posted a patchset with wait-sanitize and a unit test that was merged
in ndctl v80.[3,4] A quick look at the code tells me Dan did not just
grab your implementation. It differs.
While the implementations of wait-sanitize are slightly different between
what I posted and Dan's patches, it is not fundamentally very different
(poll on the file).
Can you confirm that the two features as a set are what you want today?
I can.
Are the last comments from Vishal and I addressed? [2]
So I had made sure to address the libcxl.sym comments but just noticed
that the -s option wanted to be removed as it will the the default. So
only have the -e option for secure erase alternative (and not allow for
both to be specified at the same time).
cxl sanitize-memdev -e mem0 <-- secure erase
cxl sanitize-memdev mem0 <-- sanitize
Can the existing unit test be expanded with a sanitize-memdev test case?
Good point. Yeah we could trivially replace those
echo 1 > /sys/bus/cxl/devices/${inactive}/security/sanitize && err $LINENO
with
"$CXL" sanitize-memdev $inactive || err $LINENO
Thanks,
Davidlohr
