On Tue, Feb 11, 2025 at 07:40:18PM -0800, [email protected] wrote:
> From: Alison Schofield <[email protected]>
>
> The ndctl cli interface is built around an imported perf cli
> infrastructure which was originally from git. [1]
>
> A recent static analysis scan exposed an integer overflow issue in
> sysbuf_read() and although that is fixable, the function is not used
^^^
strbuf_read()
> in ndctl. Further examination revealed additional unused functionality
> in the string buffer handling import and a subset of that has already
> been obsoleted from the perf cli.
>
> In the interest of not maintaining unused code, remove the unused code
> in util/strbuf.h,c. Ndctl, including cxl-cli and daxctl, are mature
> cli's so it seems ok to let this functionality go after 14 years.
>
> In the interest of not touching what is not causing an issue, the
> entirety of the original import was not reviewed at this time.
>
> [1] 91677390f9e6 ("ndctl: import cli infrastructure from perf")
>
> Signed-off-by: Alison Schofield <[email protected]>
> ---
> util/strbuf.c | 51 ---------------------------------------------------
> util/strbuf.h | 7 -------
> 2 files changed, 58 deletions(-)
snip
