On Tue, Sep 23, 2025 at 09:52:57PM -0700, Alison Schofield wrote: > When the --media-errors option was added to cxl list it inadvertently > changed the optional libtracefs requirement into a mandatory one. > Ndctl versions 80,81,82 no longer build without libtracefs. > > Remove that dependency. > > When libtracefs is disabled the user will see a 'Notice' level > message, like this: > $ cxl list -r region0 --media-errors --targets > cxl list: cmd_list: --media-errors support disabled at build time > > ...followed by the region listing including the output for any other > valid command line options, like --targets in the example above. > > When libtracefs is disabled the cxl-poison.sh unit test is omitted. > > The man page gets a note: > The media-error option is only available with -Dlibtracefs=enabled. > > Reported-by: Andreas Hasenack <[email protected]> > Fixes: d7532bb049e0 ("cxl/list: add --media-errors option to cxl list") > Closes: https://github.com/pmem/ndctl/issues/289 > Signed-off-by: Alison Schofield <[email protected]>
Thanks for the reviews Dan, Dave, Vishal! I've applied this to pending and I expect that is the last patch going into v83 pmem/ndctl. Heading towards a release with: https://github.com/pmem/ndctl/tree/pending
