Alison Schofield wrote: > On Mon, Feb 09, 2026 at 01:42:22PM -0600, Ira Weiny wrote: > > Alison Schofield wrote: > > > A user reports that when running daxctl they do not get a hint to > > > use sudo or root when an action fails. They provided this example: > > > > > > libdaxctl: daxctl_dev_disable: dax0.0: failed to disable > > > dax0.0: disable failed: Device or resource busy > > > error reconfiguring devices: Device or resource busy > > > > If the error returned is EACCES or EPERM why is strerror() printing the > > string for EBUSY? > > > > This does not make sense. > > That's what patch 1/2 is fixing. > > Before patch 1/2, errno was used after close() which could modify errno. > The EACCES/EPERM was overwritten and the return error appears as EBUSY. > > Now, patch 1/2 preserves the errno so the real failure is reported, and > patch 2/2 adds a helpful hint when that preserved errno is a privilege > issue. > > Better?
Ah, yes much better. Reviewed-by: Ira Weiny <[email protected]> [snip]
