I'd like to see the new query component come back into action. Without it,
we easily stand the chance of an ACL list or deleted items cache breaking
queries.

For those wondering what this component does, it was found that when a
large number of things are deleted or very large ACL is encountered, we add
enough terms to the query to go over the 1024 limit (configurable). Mark
introduced a query component that works around adding these to the query to
keep from hitting the limit but achieve the same result (ACLs applied,
deleted items not shown).


On Mon, Jun 25, 2012 at 12:02 AM, Mark Triggs <[email protected]> wrote:

> Hi all,
>
> A little while ago Carl and I did some work on changing the way ACLs get
> applied to search results.  This led to a custom Solr query component
> being checked in[1] that does away with the huge boolean queries
> currently used to apply ACLs.
>
> A bug relating to escaping caused the query component to make the
> integration tests run slowly[2].  After that got fixed, it seems that
> another issue[3] triggered the Solr bundle to be rolled back to an older
> version, and the query component got removed with it[4].
>
> Does anyone know if there are any remaining reasons to leave the query
> component disabled?  I've just switched it back on in the master branch
> and it didn't affect the integration tests.  The changes I made are
> here:
>
>
> https://github.com/marktriggs/nakamura/commit/aa22b23f36a22cea1c39ff45ee9a2d17c44c70e3
>
> Thanks,
>
> Mark
>
>
>
> Footnotes:
> [1]
> https://github.com/sakaiproject/nakamura/blob/master/bundles/solr/src/main/java/org/sakaiproject/nakamura/solr/NakamuraQueryComponent.java
> [2]  https://jira.sakaiproject.org/browse/KERN-2787
> [3]  https://jira.sakaiproject.org/browse/KERN-2632
> [4]  https://jira.sakaiproject.org/browse/KERN-2824
>
> --
> Mark Triggs
> <[email protected]>
> _______________________________________________
> oae-dev mailing list
> [email protected]
> http://collab.sakaiproject.org/mailman/listinfo/oae-dev
>
_______________________________________________
oae-dev mailing list
[email protected]
http://collab.sakaiproject.org/mailman/listinfo/oae-dev

Reply via email to