Hi all, This mail is mostly targeted to UI Devs but everyone should feel free to jump in.
Since a few months now the UI Development team has been gradually implementing code style changes throughout the code base. The rule of thumb is that you should apply the predefined SDK styling rules to the code you change, even if you didn't write it yourself. As of lately, we've been really strict about this and don't let anything through because of a double quote or a missing space. I'd like to propose we stop reopening for styling issues, but instead comment in the ticket that there were styling issues remaining and the assignee should pay closer attention to avoiding those in the future. The reason for this is that code review as strict as this is stalling development speed and cutting morale. Nico has a proposition as well; we change all remaining issues in one go and create a test that checks for the most common code styling issues. We'd preferably do this after 1.4.0 has been released and at a time where it's most convenient for devs (to avoid loads of merge conflicts). I wanted to raise this before the UI Development call tonight, so everyone can form an opinion and bring it up during that call. Cheers, - Bert
_______________________________________________ oae-dev mailing list oae-dev@collab.sakaiproject.org http://collab.sakaiproject.org/mailman/listinfo/oae-dev
