This is an automated email from the ASF dual-hosted git repository.

stefanegli pushed a commit to branch OAK-10763-alt
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git

commit fb405a6f9702c30fa5ddb684b58620984bc9f947
Author: stefan-egli <stefane...@apache.org>
AuthorDate: Mon Apr 15 19:39:03 2024 +0200

    OAK-10763 : non-gap orphans should not be applicable for other GC types
---
 .../jackrabbit/oak/plugins/document/VersionGarbageCollector.java      | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java
 
b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java
index e3b76f28b5..0f99368175 100644
--- 
a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java
+++ 
b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java
@@ -1249,7 +1249,9 @@ public class VersionGarbageCollector {
                     // (even though somewhere along descendants
                     // there might be a gap, it is too expensive to traverse)
                     phases.stop(GCPhase.DETAILED_GC_COLLECT_ORPHAN_NODES);
-                    return false;
+                    // return true here as this is an orphan but we decided 
not to
+                    // GC it - to prevent caller from attempting other GC types
+                    return true;
                 }
             }
 

Reply via email to