(jackrabbit-oak) branch OAK-11184 updated: OAK-11184 : moved prevNoProp logging into its own logger thus allowing separate log level to be configured - this will allow for easier debugging

[stefanegli]

This is an automated email from the ASF dual-hosted git repository.

stefanegli pushed a commit to branch OAK-11184
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git


The following commit(s) were added to refs/heads/OAK-11184 by this push:
     new 10a5fda46b OAK-11184 : moved prevNoProp logging into its own logger 
thus allowing separate log level to be configured - this will allow for easier 
debugging
10a5fda46b is described below

commit 10a5fda46ba6cbf1f222b4ee9e8cca41c5bd7768
Author: Stefan Egli <stefane...@apache.org>
AuthorDate: Tue Nov 5 18:45:21 2024 +0100

    OAK-11184 : moved prevNoProp logging into its own logger thus allowing 
separate log level to be configured - this will allow for easier debugging
---
 .../org/apache/jackrabbit/oak/plugins/document/NodeDocument.java   | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java
 
b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java
index c94691f6f1..da8a8d5882 100644
--- 
a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java
+++ 
b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java
@@ -90,6 +90,7 @@ public final class NodeDocument extends Document {
     }
 
     static final Logger LOG = LoggerFactory.getLogger(NodeDocument.class);
+    static final Logger PREV_NO_PROP_LOG = 
LoggerFactory.getLogger(NodeDocument.class + ".prevNoProp");
 
     private static final LogSilencer LOG_SILENCER = new LogSilencer();
 
@@ -1037,7 +1038,7 @@ public final class NodeDocument extends Document {
                 // any in previous documents neither.
                 // This should only occur when a property is being newly
                 // added or was deleted, then fullGC-ed and now re-added.
-                LOG.trace("getNodeAtRevision : skipping as no committed 
revision locally for path={}, key={}", path, key);
+                PREV_NO_PROP_LOG.debug("getNodeAtRevision : skipping as no 
committed revision locally for path={}, key={}", path, key);
                 continue;
             }
 
@@ -1731,7 +1732,7 @@ public final class NodeDocument extends Document {
                         // (we're not interested in the actual cache value 
btw, as finding 
                         // a cache value actually indicates "the property does 
not exist 
                         // in any previous document whatsoever" - no need for 
value check)
-                        LOG.trace("changesFor : empty changes cache hit for 
cacheKey={}", cacheKey);
+                        PREV_NO_PROP_LOG.trace("changesFor : empty changes 
cache hit for cacheKey={}", cacheKey);
                         return Collections.emptyList();
                     }
                     // cache miss - let's do the heavy lifting then
@@ -1765,7 +1766,7 @@ public final class NodeDocument extends Document {
                             wrappee.hasNext();
                             if (!childrenPropRevFound.get()) {
                                 // then let's cache that
-                                LOG.trace("changesFor : caching empty changes 
for cacheKey={}", cacheKey);
+                                PREV_NO_PROP_LOG.debug("changesFor : caching 
empty changes for cacheKey={}", cacheKey);
                                 prevNoPropCache.put(cacheKey, 
StringValue.EMPTY);
                             }
                             return wrappee;