[ 
https://issues.apache.org/jira/browse/OAK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235455#comment-13235455
 ] 

Thomas Mueller commented on OAK-28:
-----------------------------------

> Why do we need to implement a query parser in the jcr bindings module then?

Actually, it seems we don't need the parser in oak-jcr. I was wrong about that. 
I will update the issue description.

> Therefore I'd rather not parse the query statement in the jcr binding and 
> pass the map of bind variables/values.

I would do the same. 

> setLimit() and setOffset()

As for "limit" and "offset", it's not a problem to support them within the 
query statement as well - supporting it would actually simplify testing, as 
more tests can be written in 
the script style currently used in 
oak-core/src/test/org.apache.jackrabbit.oak.query/queryTest.txt

                
> Query implementation
> --------------------
>
>                 Key: OAK-28
>                 URL: https://issues.apache.org/jira/browse/OAK-28
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: core, jcr
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>              Labels: query
>         Attachments: OakToJcrQueryTreeConverter.java
>
>
> A query engine needs to be implemented. 
> A query parser in oak-core should be able to handle xpath, sql2 and 
> optionally other query languages. The jcr component must generate a valid 
> query in one of those languages from JQOM queries and pass that statement 
> along with name space mappings to the oak-core. 
> We need to:
> * Define the oak-core API for handling queries. How are do we handle name 
> space mappings, limit and size
> * Implement a query builder in the jcr component which takes care of 
> translating JQOM queries 
> * Implement a query parser in oak-core and decide on a versatile AST 
> representation which works with all query languages and which is extensible 
> to future query languages.
> * Implement the actual query execution engine which interprets the query AST

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to