On 14.8.12 22:10, Jukka Zitting wrote:
Hi,
On Tuesday, August 14, 2012, Michael Dürig wrote:
This change will prevent the repository from shutting down until all
observation events from a running diff are delivered. Depending on the
number of changes in the tree this could delay shutdown for quite some time.
Hmm, if that's the case, then it's a bug. Is there a test case?
No test case but its obvious from the code. There was a condition
variable earlier which signalled a pending shut down (or
ObservationManager.dispose) to the ChangeProcessor. The later used that
to exit its run method.
Michael
In general the repository shutdown should IMO *never* block for any
background tasks. A "kill -9" on a JVM process should IMHO be considered a
valid way to shutdown a repository running inside the JVM, so there's
nothing that the repository should expect a background task to finish in
time for shutdown.
BR,
Jukka Zitting
