Hi,

Recently Alex pointed that we do not close the NodeStore in the
oak-run console which brought up the topic of how to support closing
of NodeStore. Currently both SegmentNodeStore and DocumentNodeStore
need to be closed properly

There are couple of options

1. Make NodeStore API extend Closeable
2. Have the actual implementations (i.e. SegmentNodeStore and
DocumentNodeStore) implement
   Closeable and the close logic does an instanceof check to determine
if the NodeStore has to be
   closed or not

Which approach to take?

Chetan Mehrotra

Reply via email to