Hi

>From a user's perspective, it concerns me that item names are being changed 
>when migrating from Jackrabbit (2) to Oak (Jackrabbit 3) … This may (or may 
>not) cause applications to mysteriously break.

Just my $.02 to consider — not a requirement to change OAK-1624

Regards
Felix

Am 13.06.2014 um 17:36 schrieb Tobias Bocanegra <tri...@apache.org>:

> On Fri, Jun 13, 2014 at 6:51 AM, Julian Reschke <julian.resc...@gmx.de> wrote:
>> On 2014-06-13 15:37, Tobias Bocanegra wrote:
>>> 
>>> On Thu, Jun 12, 2014 at 10:55 PM, Julian Reschke <julian.resc...@gmx.de>
>>> wrote:
>>>> 
>>>> On 2014-06-13 02:14, Tobias Bocanegra wrote:
>>>>> 
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> according to [0] oak does not allow a non-space whitespace in the
>>>>> name. this is different than in jackrabbit. also it should be allowed
>>>>> based on [1].
>>>>> 
>>>>> the problem at hand is, that we have content with 'no-break-space'
>>>>> chars in node names, that doesn't install in oak anymore.
>>>>> 
>>>>> regards, toby
>>>>> 
>>>>> [0]
>>>>> 
>>>>> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/Namespaces.java#L252
>>>>> 
>>>>> [1] http://www.w3.org/TR/xml/#NT-Char
>>>> 
>>>> 
>>>> 
>>>> Looking at Jackrabbit's PathParser
>>>> (org.apache.jackrabbit.spi.commons.conversion), it seems that non-SP
>>>> whitespace characters aren't allowed here either.
>>> 
>>> 
>>> but creating nodes with such chars works. so, is it a bug or not?
>> 
>> 
>> Does it?
>> 
>> Maybe there's a higher-level component that actually converts non-SP
>> whitespace to proper whitespace before passing the name to JCR?
> 
> in jackrabbit, the PathParser treats all non-sp-ws as tab-characters:
> [2], but does not complain about it.
> 
> however, if we keep this restriction, it should also be "converted"
> during a content upgrade.
> I created an issue to track this [3].
> 
> regards, toby
> 
> [2] 
> https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/conversion/PathParser.java#L257
> [3] https://issues.apache.org/jira/browse/OAK-1891

Reply via email to