I proposed a patch to OAK-3107 implementing the solution outlined in the description of the issue. I run unit and integration tests, and it looks like this doesn't break anything. Can somebody review if the solution is going in the right direction?
2015-07-15 11:48 GMT+02:00 Francesco Mari <mari.france...@gmail.com>: > In addition, I still think that SegmentWriter should be able to store > blob IDs longer that 4096 bytes, since there is no limit to the length > of the blob ID returned by a BlobStore. I opened OAK-3107 as a way to > start a discussion on this topic. > > 2015-07-15 10:59 GMT+02:00 Francesco Mari <mari.france...@gmail.com>: >> Hi all, >> >> While debugging OAK-1842, I figured out that SegmentWriter is too >> permissive when checking the length of binary IDs. For some values of >> the length, invalid data is written into the segment. When reading >> this data, an IllegalStateException is thrown. >> >> I describe the problem in more detail and propose a patch in OAK-3105. >> Can somebody review it?