> So we can have a marker value to indicate empty
agreed, we could have null, '' and/or 'default' basically map to the same
idea: sync index.

> And there we introduce something like IndexingContext which folds in 
> IndexUpdateCallback,
indexing mode, index path, CommitInfo etc
sounds interesting, this looks like a good option.


best,
alex



On Wed, Aug 3, 2016 at 11:53 AM, Chetan Mehrotra <[email protected]>
wrote:

> On Wed, Aug 3, 2016 at 2:23 PM, Alex Parvulescu
> <[email protected]> wrote:
> > extend the current index definition
> > for the 'async' property and allow multiple values.
>
> That should work and looks like natural extension of the flag. Just
> that having empty value in array does not look good (might confuse
> people in ui). So we can have a marker value to indicate empty
>
> >What about overloading the 'IndexUpdateCallback' with a 'isSync()' method
> > coming from the 'IndexUpdate' component. This will reduce the change
> > footprint and only components that need to know this information will use
> > it.
>
> That can be done. Going forward we also need to pass in CommitInfo or
> something like that (see other mail).
>
> Another option can be to have a new interface for IndexEditorProvider
> (on same line as AdvancedQueryIndex > QueryIndex). So the editor
> implementing new interface would have the extra params passed in. And
> there we introduce something like IndexingContext which folds in
> IndexUpdateCallback, indexing mode, index path, CommitInfo etc
>
> Chetan Mehrotra
>

Reply via email to