Assuming that we decide to adapt RepositoryGrowthTest to use SegmentTarFixture, the new FileStore implementation doesn't expose a public size() method. This means that RepositoryGrowthTest will not be able to access the repository size.
>From an implementation point of view, RepositoryGrowthTest violates the encapsulation of the benchmark framework multiple times. Since RepositoryGrowthTest seems to work only when a SegmentFixture is used, it might be more convenient to refactor RepositoryGrowthTest and make this dependency explicit and the code cleaner. Since there is obviously some work to do to adapt RepositoryGrowthTest, it is worth asking how many times somebody checked the results of this benchmark since it was introduced in 2014. If nobody finds RepositoryGrowthTest useful, we might as well throw it away. 2017-03-02 13:56 GMT+01:00 Andrei Dulceanu <[email protected]>: > Hi, > > Working on OAK-5834 [1], which is about removing the deprecated oak-segment > module, I came across RepositoryGrowthTest. This benchmark uses *only* the > deprecated SegmentFixture. Does anyone have any hints regarding what to do > with this benchmark? Is it safe to remove it entirely, or does it need to > be adapted to work with SegmentTarFixture? > > Regards, > Andrei > > [1] https://issues.apache.org/jira/browse/OAK-5834
