I tend to agree with Davide. Especially since the use case is for benchmarking only. Isn't there an alternative way where the node store could be exposed via the the benchmark's fixture?

Michael

On 25.09.17 11:00, Davide Giannella wrote:
On 25/09/2017 07:05, Chetan Mehrotra wrote:
One way can be to expose NodeStore instance from the Oak class. Would
that be ok to do?

I don't like it very much as it would make it too easy to access the
NodeStore from a consumer pov. `Oak` itself is already low level
therefore I'm not strongly objecting for adding such feature. However as
the Oak object accept the NodeStore already as part of the constructor I
would see if it is feasible to keep a reference to the NodeStore in the
AbstractTest itself and use it during repository construction.

HTH
Davide


Reply via email to