Hi Konrad,

As written in JCRVLT-345, I don't think that we should add a lot of
validation features into the filevault-package-m-p, as validation can
happen more often during the lifetime of a package (e.g. before deployment
if developer and deployer/operation are not identical). I would move all
validations into a dedicated plugin.

Regarding your question: It does not matter what type of index, so b). You
can identify these nodes simply by looking at the node-types. All non-index
definitions should be ignored in this validation.

Jörg

Am Mi., 24. Juli 2019 um 12:14 Uhr schrieb Konrad Windszus <konra...@gmx.de
>:

> Hi,
> the filevault-package-maven-plugin validates if a package contains a new
> index definition. This behaviour can be disabled via the
> "allowIndexDefinitions" parameter (
> https://jackrabbit.apache.org/filevault-package-maven-plugin/generate-metadata-mojo.html#allowIndexDefinitions)
> . There was a bug recently reported about that at
> https://issues.apache.org/jira/browse/JCRVLT-343?focusedCommentId=16891508&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16891508
> because there was a rep:policy node modified below oak:index. It is not
> 100% clear under which circumstances the validation should fail:
> a) only for synchronous index definition nodes
> b) for all index node definitions
> c) for all changes below /oak:index
>
> I tend to say actually only a) might lead to issues and therefore only
> those nodes should make the build optionally fail.
> WDYT?
>
> Thanks,
> Konrad



-- 
Cheers,
Jörg Hoh,

http://cqdump.wordpress.com
Twitter: @joerghoh

Reply via email to