rishabhdaim commented on code in PR #1551:
URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650849122
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##########
@@ -170,6 +174,8 @@ public class DocumentNodeStoreBuilder<T extends
DocumentNodeStoreBuilder<T>> {
private boolean clusterInvisible;
private boolean throttlingEnabled;
private boolean fullGCEnabled;
+ private Set<String> fullGCIncludePaths = of();
+ private Set<String> fullGCExcludePaths = of();
Review Comment:
fixed in
https://github.com/apache/jackrabbit-oak/pull/1551/commits/55f310e2d65cfe3208ff7688ce93787eccb0cfba
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java:
##########
@@ -260,6 +260,27 @@
"are separated with '::'. Example:
-Doak.documentstore.persistentCacheIncludes=/content::/var")
String[] persistentCacheIncludes() default {"/"};
+ @AttributeDefinition(
+ name = "Full GC Include Paths",
+ description = "Paths which should be included in full garbage
collection." +
+ "Empty value means all paths are included. " +
+ "Any path which is added to both include & exclude paths,
" +
+ "would be removed from included paths." +
+ "Note that this value can be overridden with a system
property " +
+ "'oak.documentstore.fullGCIncludes' where paths " +
+ "are separated with '::'. Example:
-Doak.documentstore.fullGCIncludes=/content::/var")
+ String[] fullGCIncludes() default {};
+
+ @AttributeDefinition(
+ name = "Full GC Exclude Paths",
+ description = "Paths which should be excluded from full Garbage
collection." +
+ "Empty value means no paths are excluded." +
+ "Any path added to excluded list would be removed from
include paths (if present)." +
+ "Note that this value can be overridden with a system
property " +
+ "'oak.documentstore.fullGCExcludes' where paths " +
+ "are separated with '::'. Example:
-Doak.documentstore.fullGCExcludes=/content::/var")
+ String[] fullGCExcludes() default {};
Review Comment:
fixed in
https://github.com/apache/jackrabbit-oak/pull/1551/commits/55f310e2d65cfe3208ff7688ce93787eccb0cfba
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java:
##########
@@ -260,6 +260,27 @@
"are separated with '::'. Example:
-Doak.documentstore.persistentCacheIncludes=/content::/var")
String[] persistentCacheIncludes() default {"/"};
+ @AttributeDefinition(
+ name = "Full GC Include Paths",
+ description = "Paths which should be included in full garbage
collection." +
+ "Empty value means all paths are included. " +
+ "Any path which is added to both include & exclude paths,
" +
+ "would be removed from included paths." +
+ "Note that this value can be overridden with a system
property " +
+ "'oak.documentstore.fullGCIncludes' where paths " +
+ "are separated with '::'. Example:
-Doak.documentstore.fullGCIncludes=/content::/var")
Review Comment:
fixed in
https://github.com/apache/jackrabbit-oak/pull/1551/commits/55f310e2d65cfe3208ff7688ce93787eccb0cfba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
