nfsantos commented on code in PR #1738:
URL: https://github.com/apache/jackrabbit-oak/pull/1738#discussion_r1776918670
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/CompositeIndexer.java:
##########
@@ -86,6 +87,13 @@ public Set<String> getRelativeIndexedNodeNames() {
return result;
}
+ @Override
+ public String getIndexName() {
+ // This is susceptible to infinite recursion if a composite indexer
contains itself, directly or indirectly.
Review Comment:
Yes, I agree, it should be a warning in the public documentation of the
class. The users of this class have to be aware to avoid this issue. I updated
the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
