tihom88 commented on code in PR #1734:
URL: https://github.com/apache/jackrabbit-oak/pull/1734#discussion_r1799887512
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -76,12 +76,21 @@ public class IndexerSupport {
private File indexDefinitions;
private final String checkpoint;
private File existingDataDumpDir;
+ private long minModified;
public IndexerSupport(IndexHelper indexHelper, String checkpoint) {
this.indexHelper = indexHelper;
this.checkpoint = checkpoint;
}
+ public long getMinModified() {
+ return minModified;
+ }
+
+ public void setMinModified(long minModified) {
+ this.minModified = minModified;
Review Comment:
[oak
documentation](https://jackrabbit.apache.org/oak/docs/nodestore/documentmk.html)
mentions:
`The _modified field contains an indexed low-resolution timestamp when the
node was last modified. The time resolution is five seconds. This field is also
updated when a branch commit modifies a node.
`
If I am understanding it correctly anything updated till 4 sec will be set
to 0 as per time resolution.
i.e for a 14th second update _modified property will be set to 10 sec.
For a 29th second update _modified property will be set to 25 sec.
So to make sure that we don't miss any update
I think minModified should be
`this.minModified = minModified - minModified/5`
@stefan-egli , @mreutegg am I correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
