thomasmueller commented on PR #1734: URL: https://github.com/apache/jackrabbit-oak/pull/1734#issuecomment-2413218009
> we would miss the deleted nodes - right ? Only for those deleted nodes that the "diff" doesn't see. (My plan is to run _both_ the diff _and_ the top-up.) > Eventually this would lead to larger and larger index stores ? Until the bugs in the "diff" parts are fixed, yes. But the verification would still notice it, and so we could re-download everything once we see that it's too many. > Let's say a bulk delete on a large content repository just before the top up. If the bugs in the "diff" logic are not fixed, then I think the behavior is the same as it is now. If it turns out that the "diff" logic can not be fixed easily, then we could also change the download logic (pipelined strategy) to emit "removed" entries. But I think we don't need to implement this logic currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
