stefan-egli commented on PR #1805: URL: https://github.com/apache/jackrabbit-oak/pull/1805#issuecomment-2443948541
> Regarding the explicit check, I don't think this is necessary Fair enough. Two unrelated additional comments: * the DocumentNodeStore is not properly disposed. You can see this by running the oak-run command consecutively : the second start will have to wait 2min for the lease timeout of the first non-gracefully shut down run. We should ensure a graceful disposal. * what might be useful is to add the base path where the garbage is generated to - such that the user immediately knows (and doesn't eg have to consult the source code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
