steffenvan commented on code in PR #1804:
URL: https://github.com/apache/jackrabbit-oak/pull/1804#discussion_r1821158375
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java:
##########
@@ -578,10 +588,70 @@ private boolean visitTerm(String propertyName, String
text, String boost, boolea
return true;
}
});
-
+
return Query.of(q -> q.bool(result.get()));
}
+ private ObjectBuilder<BoolQuery> inference(BoolQuery.Builder b, String
propertyName, String text, PlanResult pr, boolean dbEnabled) {
+ ElasticIndexDefinition.InferenceDefinition.Query q = null;
Review Comment:
Could you write a comment that just briefly explains when the inference
query could be null and what happens when that is the case? Looks like it will
just do a basic fulltext search, but am not 100% sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
