rishabhdaim commented on code in PR #1901:
URL: https://github.com/apache/jackrabbit-oak/pull/1901#discussion_r1883510381
##########
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java:
##########
@@ -1229,22 +1229,24 @@ private void renameKeys() throws DataStoreException {
long count = 0;
try {
Thread.currentThread().setContextClassLoader(
- getClass().getClassLoader());
+ getClass().getClassLoader());
Review Comment:
please revert this.
##########
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java:
##########
@@ -1229,22 +1229,24 @@ private void renameKeys() throws DataStoreException {
long count = 0;
try {
Thread.currentThread().setContextClassLoader(
- getClass().getClassLoader());
+ getClass().getClassLoader());
ObjectListing prevObjectListing = s3service.listObjects(bucket);
List<DeleteObjectsRequest.KeyVersion> deleteList = new
ArrayList<DeleteObjectsRequest.KeyVersion>();
+ List<String> keysToDelete = new ArrayList<>();
int nThreads =
Integer.parseInt(properties.getProperty("maxConnections"));
ExecutorService executor = Executors.newFixedThreadPool(nThreads,
- new NamedThreadFactory("s3-object-rename-worker"));
+ new NamedThreadFactory("s3-object-rename-worker"));
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
