Tracked now in https://issues.apache.org/jira/browse/OAK-11389.

> On 14. Jan 2025, at 13:30, Julian Reschke <[email protected]> 
> wrote:
> 
> Am 14.01.2025 um 11:32 schrieb Konrad Windszus:
>> Hi,
>> AFAIK we don’t leverage any automated formatters nor provide a clear 
>> guidance on code formatting 
>> (https://jackrabbit.apache.org/oak/docs/participating.html#coding-style)
>> Still there is the checkstyle-maven-plugin being used which emits tons of 
>> errors with profile “pedantic” and “release” 
>> (https://github.com/apache/jackrabbit-oak/blob/fe9c04c3b567386dfb5d262971a278cd2c634a86/oak-parent/pom.xml#L1056).
>> 
>> In addition check style is leveraging the default ruleset sun_checks.xml 
>> (which I consider outdated these days with a limitation of 80 chars per 
>> line), 
>> https://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#configLocation,
>>  but we explicitly don’t fail the build.
>> 
>> As long as noone cares about the checkstyle issues and we don’t have any 
>> automated code formatting I consider this information useless.
>> In addition it spams the build log.
>> WDYT about removing this and mid term rather leverage a tool like 
>> https://github.com/diffplug/spotless/tree/main/plugin-maven?
>> 
>> Thanks,
>> Konrad
> 
> +1
> 
> Best regards, Julian

Reply via email to