kwin commented on code in PR #1993:
URL: https://github.com/apache/jackrabbit-oak/pull/1993#discussion_r1938327804
##########
oak-core-spi/src/main/java/org/apache/jackrabbit/oak/namepath/NameMapper.java:
##########
@@ -63,16 +63,35 @@ public interface NameMapper {
Map<String, String> getSessionLocalMappings();
/**
- * Returns the JCR name for the given Oak name. The given name is
+ * Returns the JCR name in qualified form for the given Oak name. The
given name is
* expected to have come from a valid Oak repository that contains
* only valid names with proper namespace mappings. If that's not
* the case, either a programming error or a repository corruption
* has occurred and an appropriate unchecked exception gets thrown.
*
* @param oakName Oak name
- * @return JCR name
+ * @return JCR name in qualified form
+ *
+ * @see <a
href="https://s.apache.org/jcr-2.0-spec/3_Repository_Model.html#3.2.5.2%20Qualified%20Form">JCR
2.0, 3.2.5.2 Qualifed Form</a>
*/
@NotNull
String getJcrName(@NotNull String oakName);
+ /**
+ * Returns the JCR name in expanded form for the given Oak name. The given
name is
+ * expected to have come from a valid Oak repository that contains
+ * only valid names with proper namespace mappings. If that's not
+ * the case, either a programming error or a repository corruption
+ * has occurred and an appropriate unchecked exception gets thrown.
+ *
+ * @param oakName Oak name
+ * @return JCR name in expanded form
+ * @since Oak 1.76.0
+ * @throws IllegalStateException in case the namespace URI for the given
Oak name cannot be resolved
Review Comment:
Well, in all other context it is about resolving, e.g.
https://jackrabbit.apache.org/api/2.22/org/apache/jackrabbit/spi/commons/conversion/NameResolver.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]