kwin commented on code in PR #2081:
URL: https://github.com/apache/jackrabbit-oak/pull/2081#discussion_r1961982968


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/impl/LocalNameMapper.java:
##########
@@ -64,8 +64,8 @@ public synchronized String getJcrName(@NotNull String 
oakName) {
                 String oakPrefix = oakName.substring(0, colon);
                 String uri = getNamespacesProperty(oakPrefix);
                 if (uri == null) {
-                    throw new IllegalStateException(
-                            "No namespace mapping found for " + oakName);
+                    //the namespace has a local mapping, but no global 
mapping, which is fine

Review Comment:
   I don't think this comment is accurate, this only means that there is some 
local namespace mapping (irrespective for which prefix/uri combination) but the 
prefix is not registered globally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to