reschke commented on code in PR #2120:
URL: https://github.com/apache/jackrabbit-oak/pull/2120#discussion_r1971745977
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/AstElement.java:
##########
@@ -41,12 +41,12 @@ protected String protect(Object expression) {
}
}
- protected String quote(String pathOrName) {
+ protected static String quote(String pathOrName) {
pathOrName = pathOrName.replaceAll("]", "]]");
return '[' + pathOrName + ']';
Review Comment:
While we are at it, I would collapse that into a single line, avoiding the
reassignment...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
