fabriziofortino commented on code in PR #2099:
URL: https://github.com/apache/jackrabbit-oak/pull/2099#discussion_r1977259186


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticPropertyDefinition.java:
##########
@@ -50,6 +61,14 @@ public 
ElasticPropertyDefinition(IndexDefinition.IndexingRule idxDefn, String no
                     getOptionalValue(defn, PROP_CANDIDATES, 
DEFAULT_CANDIDATES));
         }
         this.useInFullTextQuery = this.dynamicBoost && getOptionalValue(defn, 
PROP_USE_IN_FULL_TEXT_QUERY, true);
+        boolean flattened = getOptionalValue(defn, PROP_IS_FLATTENED, 
PROP_IS_FLATTENED_DEFAULT);
+        if (analyzed) {

Review Comment:
   I am wondering if we should actually fail in this case.
   If we don't, the index won't be created as flattened and it might fail while 
indexing in case the number of fields exceeds the maximum.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to