rishabhdaim commented on PR #2212: URL: https://github.com/apache/jackrabbit-oak/pull/2212#issuecomment-2782366022
> It looks OK as far as I see, but I'm not sure about the security part. > > Possibly memory usage could be much higher than with the current ImmutableSet. We have already done the micro benchmarks for `SetUtils.toLinkedSet` vs `ImmutableSet` and the results are here: https://github.com/apache/jackrabbit-oak/pull/2178#issuecomment-2723629655 it seems that using Java's `LinkedHashSet` uses lesser memory because it doesn't uses another data structure (i.e. ArrayList in case of ImmutableSet) to store insertion order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
