shodaaan commented on code in PR #2216:
URL: https://github.com/apache/jackrabbit-oak/pull/2216#discussion_r2058150577
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/FullGCStatsCollectorImpl.java:
##########
@@ -83,9 +84,15 @@ class FullGCStatsCollectorImpl implements
FullGCStatsCollector {
private final CounterStats counter;
private final CounterStats failureCounter;
+ private static String METRICS_QUALIFIED_NAME_PREFIX;
FullGCStatsCollectorImpl(StatisticsProvider provider) {
+ this(provider, false);
+ }
+
+ FullGCStatsCollectorImpl(StatisticsProvider provider, boolean pushMetrics)
{
this.provider = provider;
+ this.METRICS_QUALIFIED_NAME_PREFIX = pushMetrics ?
FULL_GC_PUSH_METRICS_PREFIX : FULL_GC;
Review Comment:
Done, thank you for the suggestion.
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/FullGCStatsCollectorImpl.java:
##########
@@ -37,6 +37,7 @@
*/
class FullGCStatsCollectorImpl implements FullGCStatsCollector {
+ static final String FULL_GC_PUSH_METRICS_PREFIX = "oak_FullGC";
Review Comment:
Done, thank you for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
