rishabhdaim commented on code in PR #2255:
URL: https://github.com/apache/jackrabbit-oak/pull/2255#discussion_r2063756301
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1007,6 +1004,9 @@ protected boolean removeEldestEntry(Entry<Path, Boolean>
eldest) {
fromModifiedMs = lastDoc.getModified() == null
? oldModifiedMs : SECONDS.toMillis(lastDoc.getModified());
fromId = lastDoc.getId();
}
+ if (fullGCMetricsExporter != null) {
+ fullGCMetricsExporter.onIterationComplete();
+ }
Review Comment:
from what I understand is that, you are sending the metrics everytime
instead of sending it only in case of having a garbage as done earlier, correct
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
