rishabhdaim commented on code in PR #2314:
URL: https://github.com/apache/jackrabbit-oak/pull/2314#discussion_r2115695584


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java:
##########
@@ -2551,7 +2550,7 @@ private static final class ValueComparator implements
 
         static final Comparator<Entry<Revision, String>> REVERSE = 
Collections.reverseOrder(INSTANCE);
 
-        private static final Ordering<String> STRING_ORDERING = 
Ordering.natural().nullsFirst();
+        private static final Comparator<String> STRING_ORDERING = 
Comparator.nullsLast(Comparator.naturalOrder());

Review Comment:
   fixed in 
https://github.com/apache/jackrabbit-oak/pull/2314/commits/4a32eafde4cfca3452207d34636c8c08e72a87c8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to