rishabhdaim commented on code in PR #2380:
URL: https://github.com/apache/jackrabbit-oak/pull/2380#discussion_r2209229075
##########
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/JournalReader.java:
##########
@@ -54,7 +55,13 @@ protected JournalEntry computeNext() {
String line = null;
while ((line = reader.readLine()) != null) {
if (line.indexOf(' ') != -1) {
- List<String> splits = Splitter.on(' ').splitToList(line);
+ List<String> splits;
+ if (line.trim().isEmpty()) {
+ // special case handling for empty lines where we need
to split by space
+ splits =
Arrays.stream(line.split("")).map(String::trim).collect(Collectors.toList());
+ } else {
+ splits = Arrays.stream(line.split("
")).collect(Collectors.toList());
+ }
Review Comment:
thanks for @mbaedke, could you please the test cases that you tried.
Also, this class has extensive test coverage and they all passed after these
changes, but still we might have missed few cases, would be more than happy to
add them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
