mreutegg commented on code in PR #1892:
URL: https://github.com/apache/jackrabbit-oak/pull/1892#discussion_r2209451113
##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentStoreMigrator.java:
##########
@@ -162,9 +162,13 @@ private void migrateArchives() throws IOException,
ExecutionException, Interrupt
List<String> targetArchives = targetManager.listArchives();
if (appendMode && !targetArchives.isEmpty()) {
- //last archive can be updated since last copy and needs to be
recopied
- String lastArchive = targetArchives.get(targetArchives.size() - 1);
- targetArchives.remove(lastArchive);
+ // last archive could have been updated since last copy and needs
to be recopied
+ try {
+ targetArchives.sort(String::compareTo);
+ targetArchives.remove(targetArchives.size() - 1);
+ } catch (UnsupportedOperationException e) {
Review Comment:
I assume UnsupportedOperationException is caught here because the List
returned by targetManager.listArchives() may be immutable. I would rather copy
the returned archive names in a new ArrayList.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
