jsedding commented on code in PR #2438:
URL: https://github.com/apache/jackrabbit-oak/pull/2438#discussion_r2261831742
##########
oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFileTest.java:
##########
@@ -53,13 +53,15 @@ public class AzureJournalFileTest {
private AzureJournalFile journal;
+ private final String rootPrefix = "oak";
+
@Before
public void setup() throws BlobStorageException {
readBlobContainerClient =
azurite.getReadBlobContainerClient("oak-test");
writeBlobContainerClient =
azurite.getWriteBlobContainerClient("oak-test");
WriteAccessController writeAccessController = new
WriteAccessController();
writeAccessController.enableWriting();
- journal = new AzureJournalFile(readBlobContainerClient,
writeBlobContainerClient, "journal.log", writeAccessController, 50);
+ journal = new AzureJournalFile(readBlobContainerClient,
writeBlobContainerClient, rootPrefix + "journal.log", writeAccessController,
50);
Review Comment:
With this change your test does not cover the fact that the issue was
introduced by a change in `AzurePersistence`.
Of course it can be argued that this is a unit test and it should only test
the class `AzureJournalFile`. However, as we have seen, this test did not catch
the regression, because this aspect was untested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
