stefan-egli commented on code in PR #2471:
URL: https://github.com/apache/jackrabbit-oak/pull/2471#discussion_r2298479102
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##########
@@ -167,22 +160,22 @@ public GCCounts(FullGCMode mode, int deletedDocGCCount,
int deletedPropsCount,
int deletedInternalPropRevsCount, int
deletedUnmergedBCCount,
int updatedFullGCDocsCount) {
this.mode = mode;
- assertTrue(deletedDocGCCount != -1);
- assertTrue(deletedPropsCount != -1);
- assertTrue(deletedInternalPropsCount != -1);
- assertTrue(deletedPropRevsCount != -1);
- assertTrue(deletedInternalPropRevsCount != -1);
- assertTrue(deletedUnmergedBCCount != -1);
- assertTrue(updatedFullGCDocsCount != -1);
+ Assert.assertTrue(deletedDocGCCount != -1);
Review Comment:
these changes look unrelated, I don't think they should be included in this
PR?
(I am also not sure why this would be changed in the first place - there are
probably ten-thousands of these fail/assertTrue - do we really need to touch
all those line, what for?)
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##########
@@ -4303,6 +4303,277 @@ private void
doLateWriteCreateChildrenGC(Collection<String> parents,
}
}
+ /**
+ * Test for the bug where FullGC EmptyProps mode incorrectly allows
+ * checkpoint reads to return old values from split documents after
+ * properties are deleted by FullGC.
+ * <p>
+ * Reproduction scenario:
+ * 1. Create document with split documents containing test property
+ * 2. Delete the property (set to null)
+ * 3. Wait 24h, then FullGC removes the property
+ * 4. Create checkpoint
+ * 5. 1ms later, write same property again (newer than checkpoint)
+ * 6. Read checkpoint -> should return null but incorrectly returns old
value from split doc
+ */
+ @Test
+ public void testFullGCEmptyPropsSplitDocumentInconsistency() throws
Exception {
Review Comment:
this looks like a duplicate of
https://github.com/apache/jackrabbit-oak/pull/2470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
