ierandra commented on code in PR #2409:
URL: https://github.com/apache/jackrabbit-oak/pull/2409#discussion_r2390322998
##########
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/binary/fixtures/datastore/AzureDataStoreFixture.java:
##########
@@ -94,12 +97,22 @@ public DataStore createDataStore() {
String connectionString =
Utils.getConnectionStringFromProperties(azProps);
try {
- CloudBlobContainer container =
Utils.getBlobContainer(connectionString, containerName);
- container.createIfNotExists();
+ boolean useSDK12 =
Boolean.parseBoolean(azProps.getProperty(AZURE_SDK_12_ENABLED, "false"));
+ Object container;
+
+ if (useSDK12) {
+ BlobContainerClient containerClient =
Utils.getBlobContainer(connectionString, containerName, null, azProps);
Review Comment:
maybe would help if you add a log here like: "Starting blob store using
azure sdk 12"
##########
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/binary/fixtures/datastore/AzureDataStoreFixture.java:
##########
@@ -94,12 +97,22 @@ public DataStore createDataStore() {
String connectionString =
Utils.getConnectionStringFromProperties(azProps);
try {
- CloudBlobContainer container =
Utils.getBlobContainer(connectionString, containerName);
- container.createIfNotExists();
+ boolean useSDK12 =
Boolean.parseBoolean(azProps.getProperty(AZURE_SDK_12_ENABLED, "false"));
+ Object container;
+
+ if (useSDK12) {
+ BlobContainerClient containerClient =
Utils.getBlobContainer(connectionString, containerName, null, azProps);
+ containerClient.createIfNotExists();
+ container = containerClient;
+ } else {
+ CloudBlobContainer blobContainer =
UtilsV8.getBlobContainer(connectionString, containerName);
Review Comment:
maybe would help if you add a log here like: "Starting blob store using
azure sdk 8"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
