mbaedke commented on code in PR #2558:
URL: https://github.com/apache/jackrabbit-oak/pull/2558#discussion_r2419764810
##########
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java:
##########
@@ -1276,22 +1253,24 @@ private void renameKeys() throws DataStoreException {
} catch (InterruptedException ie) {
}
- LOG.info("Renamed [{}] keys, time taken [{}]sec", count,
- ((System.currentTimeMillis() - startTime) / 1000));
+ LOG.info("Renamed [{}] keys, time taken [{}]sec", count,
((System.currentTimeMillis() - startTime) / 1000));
// Delete older keys.
if (!deleteList.isEmpty()) {
RemoteStorageMode mode = (RemoteStorageMode)
properties.getOrDefault(S3Constants.MODE, RemoteStorageMode.S3);
if (mode == RemoteStorageMode.S3) {
- DeleteObjectsRequest delObjsReq = new DeleteObjectsRequest(
- bucket);
int batchSize = 500, startIndex = 0, size =
deleteList.size();
int endIndex = Math.min(batchSize, size);
while (endIndex <= size) {
-
delObjsReq.setKeys(Collections.unmodifiableList(deleteList.subList(
- startIndex, endIndex)));
- DeleteObjectsResult dobjs =
s3service.deleteObjects(delObjsReq);
+ int finalStartIndex = startIndex;
+ int finalEndIndex = endIndex;
Review Comment:
What are these good for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
