ierandra commented on code in PR #2409:
URL: https://github.com/apache/jackrabbit-oak/pull/2409#discussion_r2390546931
##########
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureDataStore.java:
##########
@@ -41,11 +43,18 @@ public class AzureDataStore extends
AbstractSharedCachingDataStore implements Co
protected Properties properties;
- private AzureBlobStoreBackend azureBlobStoreBackend;
+ private AbstractAzureBlobStoreBackend azureBlobStoreBackend;
+
+ private final boolean useAzureSdkV12 =
SystemPropertySupplier.create("blob.azure.v12.enabled", false).get();
@Override
protected AbstractSharedBackend createBackend() {
- azureBlobStoreBackend = new AzureBlobStoreBackend();
+ if (useAzureSdkV12) {
+ azureBlobStoreBackend = new AzureBlobStoreBackend();
Review Comment:
maybe would help if you add a log here like: "Starting blob store using
azure sdk 12"
##########
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureDataStore.java:
##########
@@ -41,11 +43,18 @@ public class AzureDataStore extends
AbstractSharedCachingDataStore implements Co
protected Properties properties;
- private AzureBlobStoreBackend azureBlobStoreBackend;
+ private AbstractAzureBlobStoreBackend azureBlobStoreBackend;
+
+ private final boolean useAzureSdkV12 =
SystemPropertySupplier.create("blob.azure.v12.enabled", false).get();
@Override
protected AbstractSharedBackend createBackend() {
- azureBlobStoreBackend = new AzureBlobStoreBackend();
+ if (useAzureSdkV12) {
+ azureBlobStoreBackend = new AzureBlobStoreBackend();
+ } else {
+ azureBlobStoreBackend = new AzureBlobStoreBackendV8();
Review Comment:
maybe would help if you add a log here like: "Starting blob store using
azure sdk 8"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
