thomasmueller commented on code in PR #2751:
URL: https://github.com/apache/jackrabbit-oak/pull/2751#discussion_r2851360023


##########
oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndexTest.java:
##########
@@ -303,5 +305,73 @@ private void storeDiff(NodeStore store, String timestamp, 
String json) throws Co
             }
         }
     }
+
+    // verify @lucene and @elasticsearch are cleared
+    @Test
+    public void cleanedAndNormalizedRemoveAtLucene() {
+        assertEquals("{\n"
+                + "  \"test\": 4,\n"
+                + "  \"test@abc\": 3\n"
+                + "}",
+                DiffIndexMerger.cleanedAndNormalized(JsonObject.fromJson(
+                        "{\"test@lucene\":1, \"test@elasticsearch\": 2, 
\"test@abc\": 3, \"test\": 4}", true)).toString());
+    }
+
+    // verify @lucene and @elasticsearch are cleared

Review Comment:
   The term "namespace" is already used for JCR (actualy XML) and means 
something else, so I think this would be confusing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to