rishabhdaim opened a new pull request, #2776:
URL: https://github.com/apache/jackrabbit-oak/pull/2776
## Summary
- Adds `OfflineCompactionGcLogTest` — three regression tests that directly
expose the bug where offline compaction (`compactFull()` + `cleanup()` as
separate calls) never writes a gc.log entry
- All three tests fail against the unfixed code and pass once the fix
retaining `CompactionResult` across the two calls is applied
## Changes
- `oak-segment-tar/src/test/java/.../file/OfflineCompactionGcLogTest.java`
(new file)
- `testOfflineCompactionPersistsGcLog` — basic offline compaction
scenario: verifies gc.log has a valid entry with non-empty root id and
incremented GC generation
- `testCleanupFirstCompactOkCleanupGcLogWritten` — cleanup → compact →
cleanup: pre-compaction cleanup must not write gc.log; only the post-compaction
cleanup should
- `testCompactOkCleanupCleanupGcLogHasExactlyOneEntry` — compact → cleanup
→ cleanup: first cleanup writes, second must not write a duplicate
## Test Plan
- [ ] All three new tests fail on unfixed code (regression tests)
- [ ] All three new tests pass once the fix is applied
## Links
- JIRA: https://issues.apache.org/jira/browse/OAK-12121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
